Add missing definition of MPI_T_PVAR_SESSION_NULL (resolve #2652) #3102
Conversation
|
I'm new to contributing to Open MPI—how do I correctly do the sign-off? Does it need to be in the first comment? |
|
Each commit must have the sign-off in the commit message. What you should probably do here is just "squash" these two commits, and then add the sign-off to the new combined commit message. In the future, you can do it most easily by just adding "-s" to the "git commit" command and it will add the sign-off for you. |
MPI_T_pvar_session_free() should reject null sessions and set *session to MPI_T_PVAR_SESSION_NULL Signed-off-by: Omri Mor <[email protected]>
|
Alright, thanks! I had tried to cheap out by using the GitHub editing interface instead of actually cloning the repository, but that was clearly a mistake. It turns out that using the command-line interface is still superior. |
omor1
changed the title
|
Looks good. This will need to be PRd to v2.0.x, v1.10.x, and v2.x. |
|
Thank you Omri Mor (@omor1) -- especially for PR'ing it to all of our release branches! |
4 participants
This pull resolves #2652 by adding the missing definition of
MPI_T_PVAR_SESSION_NULL. It also corrects an issue withMPI_T_pvar_session_free()so as to match the man page description.The only user-visible difference of the pull is that
MPI_T_pvar_session_free()will now correctly fail with a return value ofMPI_T_ERR_INVALID_SESSIONwhen thesessionparameter is not valid (that is, whenMPI_T_PVAR_SESSION_NULL == session.